Add prompts/list and prompts/get support to client
#163
+161
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dak2
force-pushed
the
add-client-prompts-support
branch
2 times, most recently
from
6eede35 to
67225d7
Compare
koic
reviewed
Oct 14, 2025
lib/mcp/client.rb
Outdated
| params: { name: name }, | ||
| }) | ||
|
|
||
| response.dig("result") || {} |
There was a problem hiding this comment.
It seems there's no test for the default value. Also, fetch might be more suitable in this kind of case.
Suggested change
| response.dig("result") || {} | |
| response.fetch("result", {}) |
There was a problem hiding this comment.
Thanks for your review!
I added test cases for this scenario and switched to using fetch.
https://github.com/modelcontextprotocol/ruby-sdk/compare/67225d7e1400f14b43c996bc165a5059df686d14..e88deb6b65beebf3a28f3800d7e5008b87636507
This commit adds two new methods to `MCP::Client`: - prompts: Lists available prompts from the server via `prompts/list` - get_prompt: Retrieves a specific prompt by name via `prompts/get` Both methods follow the same pattern as the existing resources support, including comprehensive test coverage and README documentation updates. ref. https://github.com/modelcontextprotocol/modelcontextprotocol/blob/main/docs/specification/2025-03-26/server/prompts.mdx#protocol-messages
dak2
force-pushed
the
add-client-prompts-support
branch
from
67225d7 to
e88deb6
Compare
koic
approved these changes
Oct 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This commit adds two new methods to
MCP::Client:prompts/listprompts/getBoth methods follow the same pattern as the existing resources support, including comprehensive test coverage and README documentation updates.
ref. https://github.com/modelcontextprotocol/modelcontextprotocol/blob/main/docs/specification/2025-03-26/server/prompts.mdx#protocol-messages
How Has This Been Tested?
Check existing and added test cases for this case.
https://github.com/modelcontextprotocol/ruby-sdk/pull/163/files#diff-7daf60c70888017747b710518764087efc6171bb2f5419506cf21a8ac7ef4a5a
Breaking Changes
None
Types of changes
Checklist
Additional context