Update process-wrap to v9.0 #586
Open
+11
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
T-dependencies
DaleSeo
commented
Dec 12, 2025
| self.transport.close().await?; | ||
|
|
||
| let wait_fut = Box::into_pin(child.wait()); | ||
| let wait_fut = child.wait(); |
Contributor
Author
There was a problem hiding this comment.
wait() now returns Pin<Box<dyn Future>> so it can be awaited directly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates process-wrap dependency from v8.2.1 to v9.0.0 and adapts code to API changes.
Motivation and Context
Fixes #578
The rmcp crate was using process-wrap v8.2.1, but v9.0.0 introduced breaking API changes that caused dependency conflicts for users who needed both rmcp and the latest process-wrap in their projects. This update ensures compatibility with process-wrap v9.0.0 and prevents version conflicts.
How Has This Been Tested?
All the existing unit tests are passing, and all the examples are building.
Breaking Changes
None for users of rmcp. This is an internal dependency update that maintains the same public API.
Types of changes
Checklist
Additional context