Everything server - Fix error when referring to roots #3200
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cliffhall
changed the title
cliffhall
changed the title
olaservo
approved these changes
Jan 11, 2026
Member
olaservo
left a comment
olaservo
left a comment
There was a problem hiding this comment.
Built and tested locally in inspector to double check existing functionality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In src/everything/server/roots.ts
rootsas optional inclientCapabilitiesServer Details
Motivation and Context
Referring to
clientCapabilities.rootscauses an error if the client doesn't support roots.See #2818
How Has This Been Tested?
As per the steps to reproduce in #2818
Breaking Changes
Nope.
Types of changes
Checklist
Additional context
Fixes #2818