Add missing gdlc consumers to the release App manifest entry - #55
Merged
Merged
Conversation
auth/apps.json calls itself the single source of truth for which
workflow files consume each App, but two real gdlc consumers of the
release App were missing: its own release.yml (pre-existing, mints
the release App token for the publish step) and the newly-added
live-integration-tests.yml (mints it read-only, for github-packages
live verification against GET /orgs/{org}/packages).
Found while reviewing gdlc PR #27, which wires the second consumer.
Validated with the same jq check app-manifest-validate.yml runs.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the org GitHub App auth manifest (auth/apps.json) so it accurately reflects which workflows consume the release GitHub App, specifically adding previously-missing gdlc workflow consumers.
Changes:
- Add
gdlc/.github/workflows/release.ymlto thereleaseApp’sconsumerslist. - Add
gdlc/.github/workflows/live-integration-tests.ymlto thereleaseApp’sconsumerslist.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+86
to
+87
| "gdlc/.github/workflows/release.yml", | ||
| "gdlc/.github/workflows/live-integration-tests.yml" |
| "claude-code-plugins/.github/workflows/release.yml" | ||
| "claude-code-plugins/.github/workflows/release.yml", | ||
| "gdlc/.github/workflows/release.yml", | ||
| "gdlc/.github/workflows/live-integration-tests.yml" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan