fix(validate-plugin): report malformed plugin.json/marketplace.json as validation errors

[zircote]

Summary

A JSON syntax error in .claude-plugin/plugin.json or .claude-plugin/marketplace.json threw an unhandled SyntaxError and terminated scripts/validate-plugin.mjs with a Node stack trace, instead of pushing a structured entry onto errors[] and reporting it through the gate's normal VALIDATION FAILED: path. The .mcp.json read in section 3 already guards its readJson() call; this extends the identical try/catch pattern to the other two manifest reads, so every manifest parse failure is reported alongside any other findings in the same run.

Changes

• scripts/validate-plugin.mjs: wrap the plugin.json (section 1) and marketplace.json (section 2) reads in try/catch, appending the parse message to errors[] — matching section 3's existing pattern.
• scripts/validate-plugin.mjs: add a VALIDATE_PLUGIN_ROOT env test hook so the test suite can point the validator at a fixture plugin root instead of this repository itself.
• tests/validate-plugin-manifest-parse.test.mjs: regression tests — a valid fixture root passes; a malformed plugin.json and a malformed marketplace.json each produce a structured VALIDATION FAILED: entry (exit 1, no stack trace); and both parse failures aggregate in one run instead of the first aborting the script. All four fail against the pre-fix script and pass with it.

Verification

• npm run test:hook — 273/273 pass (after npm run hydrate-schema, as CI does)
• npm run validate-plugin — OK, 0 errors
• npm run lint:md — 0 issues

Closes #182

[Copilot]

Pull request overview

This PR fixes scripts/validate-plugin.mjs so malformed JSON in .claude-plugin/plugin.json or .claude-plugin/marketplace.json is reported as a structured validation error (aggregated in errors[]) instead of crashing with an unhandled SyntaxError, and adds regression tests to lock that behavior in.

Changes:

• Wrap readJson() calls for plugin.json and marketplace.json in try/catch and append parse failures to errors[].
• Add a VALIDATE_PLUGIN_ROOT environment-variable hook to allow running the validator against a fixture root (for tests).
• Add subprocess-based regression tests covering single and aggregated manifest parse failures.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
scripts/validate-plugin.mjs	Adds guarded JSON parsing for manifests and introduces the VALIDATE_PLUGIN_ROOT hook used by tests.
tests/validate-plugin-manifest-parse.test.mjs	Adds regression coverage ensuring malformed manifests are reported via VALIDATION FAILED: without stack traces and with aggregation.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

Suppressed comments (1)

tests/validate-plugin-manifest-parse.test.mjs:56

• This assertion couples the test to the repository's current plugin name ("mif-docs"), which makes the test brittle if the manifest name ever changes. The test goal (empty VALIDATE_PLUGIN_ROOT falls back to repo root, not temp cwd) is already demonstrated by a successful exit status; if you want an additional stdout assertion, prefer something invariant like the reported error count.

    assert.match(r.stdout, /plugin: mif-docs/);