Skip to content

ops: add Vercel preview link sharing to Slack response guidelines #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
baudbot-agent wants to merge 1 commit into from
Closed

ops: add Vercel preview link sharing to Slack response guidelines #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions pi/skills/control-agent/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,8 @@ Extract the **Channel** and **Thread** values from the metadata. Use the Thread

6. **Error handling** — if something fails, tell the user in the thread. Don't silently fail.

7. **Vercel preview links** — when a PR is opened on a repo with Vercel deployments (e.g. `website`, `modem`), watch for the Vercel preview deployment to complete and share the preview URL in the Slack thread so the user can test quickly. Use the GitHub API to check deployment/check-run statuses on the PR, or ask the dev-agent to fetch the preview URL after the build finishes.

## Startup

### Step 0: Clean stale sockets + restart Slack bridge
Comment on lines +144 to 148

@sentry sentry Bot Feb 17, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The guideline for watching Vercel deployments is ambiguous. It lacks specifics on polling, timeouts, and error handling, risking inefficient or buggy implementation by the agent.
Severity: MEDIUM

Suggested Fix

Update the guideline to be more prescriptive, similar to other long-running tasks. Specify a polling interval and timeout (e.g., check every 30 seconds for up to 10 minutes). Add explicit instructions to report failures to the user in the Slack thread, consistent with guideline #6, if the deployment fails, times out, or a URL cannot be found.

Prompt for AI Agent 
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: pi/skills/control-agent/SKILL.md#L144-L148

Potential issue: The new guideline for fetching Vercel preview URLs is underspecified
compared to existing patterns for long-running tasks like the `sentry-monitor`. It lacks
instructions for polling strategy, timeouts, state management, and error handling. This
ambiguity could lead the AI agent to implement an inefficient polling mechanism,
potentially exhausting GitHub API rate limits, or to get stuck in an indefinite loop if
a deployment never completes. While the agent might reason a sensible approach, the lack
of explicit guidance creates a risk of buggy or inefficient behavior.

Did we get this right? 👍 / 👎 to inform future reviews.

Expand Down