Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): update dependency @web/test-runner-visual-regression to v0.6.1 #492

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore(deps): update dependency @web/test-runner-visual-regression to v0.6.1 #492

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
245 changes: 227 additions & 18 deletions visual-regression/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion visual-regression/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
"scripts": {
"start": "web-dev-server --open demo/ --node-resolve",
"start:watch": "web-dev-server --open demo/ --node-resolve --watch",
"pretest": "web-test-runner test/**/*.test.js --coverage --node-resolve --update-visual-baseline",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This previously failed because there were no baseline screenshots. We should probably make a pass at how you could cache screenshots from Actions, but I don't use them in my own projects, so I don't know anything about them... this builds a cache and then tests it, which is similar for this context.

"test": "web-test-runner test/**/*.test.js --coverage --node-resolve",
"test:watch": "web-test-runner test/**/*.test.js --node-resolve --watch"
},
Expand All @@ -21,6 +22,6 @@
"@open-wc/testing": "2.5.33",
"@web/dev-server": "0.1.18",
"@web/test-runner": "0.13.13",
"@web/test-runner-visual-regression": "0.4.1"
"@web/test-runner-visual-regression": "0.6.1"
}
}
4 changes: 3 additions & 1 deletion visual-regression/web-test-runner.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
import { visualRegressionPlugin } from "@web/test-runner-visual-regression/plugin";

export default {
plugins: [visualRegressionPlugin()],
plugins: [visualRegressionPlugin({
update: process.argv.includes('--update-visual-baseline'),
})],
};