feat(mocks): improve addon setup for storybook-builder #2709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 59d5386 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
bashmish
force-pushed
the
feat/mocks-improve-addon-setup-for-storybook-build
branch
from
1aef2ce
to
59d5386
Compare
thepassle
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
For Storybook 7+ (
@web/storybook-builder):@web/mocks/storybook-addonwith automatic setupinterceptorinmockRollupPlugin({ interceptor })because people now just copy the code, even if it says it's for Storybook 6
This is pretty hard to support 2 docs for very different setup side-by-side, I hope to deprecate the Storybook 6 one soon and release @web/mocks v2 without it.