Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

first step to get electron browser running, but tests not working yet #2818

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ git remote add upstream [email protected]:modernweb-dev/web.git
Now that you have cloned the repository, ensure you have node 18+ installed, then run the following command to set up the development environment.

```sh
npm install
npm clean-install
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I committed package-lock.json, and running npm clean-install will ensure that the setup is reproducible for the next person (npm install will update dependencies which always has a risk of breaking something).

npm run build
```

Expand Down
Loading