Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rollup-plugin-import-meta-assets] Fix resolving and respect external rollup option #2819

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

CGNonofr
Copy link

@CGNonofr CGNonofr commented Oct 7, 2024

The plugin currently doesn't support:

  • custom resolvers (it just resolves the path with node path tool)
  • external configuration (everything is considered as internal and bundled)

That PR implements that

Copy link

changeset-bot bot commented Oct 7, 2024

⚠️ No Changeset found

Latest commit: f784376

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

CGNonofr pushed a commit to CodinGame/monaco-vscode-api that referenced this pull request Oct 7, 2024
CGNonofr pushed a commit to CodinGame/monaco-vscode-api that referenced this pull request Oct 7, 2024
CGNonofr pushed a commit to CodinGame/monaco-vscode-api that referenced this pull request Oct 7, 2024
@bashmish
Copy link
Member

can you please add unit tests?

@CGNonofr CGNonofr force-pushed the fix-rollup-import-meta-url-resolving branch from be57128 to 1e29291 Compare October 10, 2024 15:29
@CGNonofr
Copy link
Author

can you please add unit tests?

done! fixed the current test and added a new test

@CGNonofr
Copy link
Author

Btw, I'm not sure about the "ignore if it's a directory" feature, I don't really see the point of it, and the user can now explicitely ignore it by setting it as external

@CGNonofr CGNonofr force-pushed the fix-rollup-import-meta-url-resolving branch from 1e29291 to f784376 Compare October 10, 2024 16:18
@CGNonofr
Copy link
Author

Just fixed the tests for windows

@CGNonofr
Copy link
Author

CGNonofr commented Nov 8, 2024

up?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants