Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(test-runner-browserstack): Make the local proxy configurable #2829

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(test-runner-browserstack): Make the local proxy configurable #2829

wants to merge 1 commit into from

Conversation

fbuecklers
Copy link

@fbuecklers fbuecklers commented Oct 16, 2024 •
edited
Loading

What I did

  1. I introduced a top level local options, which allow you to disable the local proxy setup. This is specially useful when you just want to test public reachable domains
  2. I have made the internal IP lookup conditional based on the capability.local flag, to make sure that it will only be run in cases it is really needed. This is also useful in CI environments where the ip command may not be available. Even an import of the module has previously crashed such CI runs.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 16, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: ec574b7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@web/test-runner-browserstack Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Westbrook
Westbrook reviewed Nov 5, 2024
View reviewed changes
Copy link
Member

@Westbrook Westbrook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please be sure to update the documentation that distributes here to support any changes that may be approved here.

@fbuecklers
Copy link
Author

Hi @Westbrook Thanks for the quick review. I have hopefully addressed your points

@fbuecklers
Copy link
Author

@Westbrook Does it look good for you now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Westbrook Westbrook Westbrook left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fbuecklers @Westbrook