fix(dev-server-core): WebSocketsPlugin: polyfill structuredClone to support older browsers (e.g. Safari < 15.4)
#2832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a876456 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
larabr
force-pushed
the
patch-3-structured-clone
branch
from
f982b7b
to
a876456
Compare
bashmish
reviewed
Oct 24, 2024
| @@ -40,7 +48,7 @@ export function webSocketsPlugin(): Plugin { | |||
| } | |||
|
|
|||
| export function stable (obj, replacer, spacer) { | |||
| var target = structuredClone(obj) | |||
| var target = ('structuredClone' in globalThis) ? structuredClone(obj) : structuredClonePolyfill(obj) | |||
There was a problem hiding this comment.
normally we recommend to setup polyfills via the polyfills loader plugin for your app/feature
https://github.com/modernweb-dev/web/tree/master/packages/dev-server-polyfill
in this case the API in question is used in the core of WDS itself, so a little bit different situation, but in the long run I think it might still be better to manage polyfills separately using the generic approach, I recommend you to consider that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
structuredCloneto support browsers that do not implement in natively, e.g. Safari below v15.4 (https://developer.mozilla.org/en-US/docs/Web/API/Window/structuredClone#browser_compatibility)