Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1880 coverage configuration 'all' option adds coverage for untested files #2833

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

miyasudokoro
Copy link

I implemented #1880, which is to enable the configuration "all" to provide coverage measurement and reporting for untested/untouched files.

  1. The core code change is in test-runner-coverage-v8 index.ts, based on the c8 implementation for "all". It generates empty reports for all included-not-excluded non-test files in the base coverage directory.
  2. To improve performance for large projects, I skip generating empty reports for files present in the local cache of test-runner-coverage-v8 index.ts, because if they are in the local cache, they have already had some coverage measured.
  3. The generated empty reports are then passed through the same v8-to-istanbul code as normal reports to ensure uniform reporting. To more easily reuse the code and improve readability, I split the existing v8ToIstanbul function into multiple smaller functions.

Copy link

changeset-bot bot commented Oct 25, 2024

⚠️ No Changeset found

Latest commit: 0540529

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant