Skip to content

skip empty tvs #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

skip empty tvs #85

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
87429f2
skip empty tvs
Apr 27, 2015
410f5e9
update check to use default tv value
Apr 27, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/Command/ExtractCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ class ExtractCommand extends BaseCommand

protected $_useResource = null;
protected $_resource = false;
protected $_defaultTVValues = array();

protected function configure()
{
Expand Down Expand Up @@ -370,10 +371,16 @@ protected function objectToArray(\xPDOObject $object)
$templateVars = $object->getTemplateVars();
foreach ($templateVars as $tv) {
/** @var \modTemplateVar $tv */
if(!isset($this->_defaultTVValues[$tv->get('id')])) {
// get default TV value
$tvObject = $this->modx->getObject('modTemplateVar', $tv->get('id'));
$this->_defaultTVValues[$tv->get('id')] = $tvObject->get('default_text');
}
if ($tv->get('value') === $this->_defaultTVValues[$tv->get('id')]) continue;
$tvs[$tv->get('name')] = $tv->get('value');
}
ksort($tvs);
$data['tvs'] = $tvs;
if(!empty($tvs)) $data['tvs'] = $tvs;;
break;

// Handle string-based categories automagically on elements
Expand Down