Pass system properties into Minecraft (+ some launch code cleanup) #3822
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the tauri feature is enabled, the resource will be loaded from Tauri resources. If the tauri feature is disabled, the resource will be extracted to a temp directory.
Gaming32
requested review from
Prospector,
AlexTMjugador,
Geometrically and
IMB11
AlexTMjugador
requested changes
Jun 25, 2025
AlexTMjugador
approved these changes
Jun 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prism and MultiMC pass some system properties into the game with various launcher metadata. This PR adds similar functionality into Theseus. There is also some cleanup of code surrounding the game's launch.
In all, it adds the following properties:
modrinth.process.args: The arguments passed to the game launch, separated by\u001fmodrinth.process.startTime: The start time, as an ISO 8601 datetimemodrinth.profile.created: The time at which the profile was created, as an ISO 8601 datetimemodrinth.profile.icon(optional): The path to the profile's icon, if anymodrinth.profile.link.project(optional): The ID of this profile's linked project, if anymodrinth.profile.link.version(optional): The ID of this profile's linked project version, if anymodrinth.profile.modified: The time at which the profile was last modified, as an ISO 8601 datetimemodrinth.profile.name: The name of the profile