Skip to content

Fix user deletion with new notifications_deliveries table for real #4473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 3, 2025
Merged

Fix user deletion with new notifications_deliveries table for real #4473

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c5ea32e
Fix user deletion with new notifications_deliveries table for real
triphora Oct 3, 2025
9f4e071
Merge branch 'main' into emma/fix-user-deletion-for-real-notification…
fetchfern Oct 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions apps/labrinth/src/database/models/user_item.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -561,18 +561,18 @@ impl DBUser {

sqlx::query!(
"
DELETE FROM notifications
WHERE user_id = $1
DELETE FROM notifications_actions
WHERE notification_id = ANY($1)
",
id as DBUserId,
&notifications
)
.execute(&mut **transaction)
.await?;

sqlx::query!(
"
DELETE FROM notifications_actions
WHERE notification_id = ANY($1)
DELETE FROM notifications_deliveries
WHERE notification_id = ANY($1)
",
&notifications
)
Expand All @@ -581,10 +581,10 @@ impl DBUser {

sqlx::query!(
"
DELETE FROM notifications_deliveries
WHERE notification_id = ANY($1)
DELETE FROM notifications
WHERE user_id = $1
",
&notifications
id as DBUserId,
)
.execute(&mut **transaction)
.await?;
Expand Down