feat: managing project versions #4811
Conversation
apps/frontend/src/components/ui/create-project-version/MultiStageModal.vue
Outdated
Show resolved
Hide resolved
| const defaultNextButton = { | ||
| icon: RightArrowIcon, | ||
| label: formatMessage(commonMessages.nextButton), | ||
| disabled: false, | ||
| color: 'standard' as const, | ||
| iconPosition: 'after' as const, | ||
| onClick: () => modal.value?.nextStage(), | ||
| } | ||
|
|
||
| const defaultBackButton = { |
There was a problem hiding this comment.
These could be put into the modal itself, e.g if true is passed rather than this btn config, it uses the defaults for that button slot
There was a problem hiding this comment.
Need to sync on how we wanna have the default config for buttons. I want it to be exportable so you can override the defaults like how I have it in this modal, and seems like can't be exported in MultiStageModal nicely, since it uses some of the component's click handlers.
…dependencies work
| (e: 'remove'): void | ||
| }>() | ||
| const { name, icon, dependencyType, versionName } = defineProps<{ |
There was a problem hiding this comment.
We don't really use this format for props (e.g usually const props = ...), but honestly its nice - maybe we should start doing it this way a bit more for things like this.
| import type { Labrinth } from '@modrinth/api-client' | ||
| import { createContext } from '@modrinth/ui' | ||
|
|
||
| export const [injectVersionsContext, provideVersionsContext] = createContext<{ |
There was a problem hiding this comment.
Hm, it would probably be better to handle this as part of the wider project page context?
No description provided.