[stdlib] Improve type refinement for pack_bits
#4345
+19
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soraros
commented
Apr 14, 2025
| return DType.uint64 | ||
| # fmt: off | ||
| return ( | ||
| DType.uint8 if n == 8 |
There was a problem hiding this comment.
Using the if expression since hlcf.if is not supported in builtin.
soraros
force-pushed
the
pack-bits-simplify
branch
from
7069a15 to
103f2d7
Compare
Signed-off-by: Yiwu Chen <[email protected]>
soraros
force-pushed
the
pack-bits-simplify
branch
from
103f2d7 to
136ec29
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So the following works without
rebind:_uintgets inlined even whennisn't concrete, cluttering tooltips and types.Can call-by-value be triggered only when
nis concrete?CC @lattner since it's related to
@always_inline("builtin").