-
-
Notifications
You must be signed in to change notification settings - Fork 305
feat(enhanced): Shared module include / exclude / nodeModulesReconstructedLookup #3736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ScriptedAlchemy
wants to merge
46
commits into
main
Choose a base branch
from
share-filter
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+11,662
−1,757
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c0c1e00 The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for module-federation-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
# Conflicts: # packages/chrome-devtools/project.json
25626cf
to
2ee38ff
Compare
…and ProvideSharedPlugin
…extract path handling
# Conflicts: # apps/website-new/docs/en/configure/experiments.mdx # package.json # packages/modernjs/project.json # packages/sdk/src/types/plugins/ModuleFederationPlugin.ts # pnpm-lock.yaml
…nd add cleanup step
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes various changes across documentation, configuration, and code enhancements for the Module Federation plugin. The key updates include the addition of new experimental features, enhancements to shared module configurations, and improvements to testing and dependency management.
Documentation Updates:
nodeModulesReconstructedLookup
experiment inapps/website-new/docs/en/configure/experiments.mdx
, explaining its purpose and usage for resolving relative imports innode_modules
.packageName
,shareKey
,strictVersion
, andversion
) for shared configurations inapps/website-new/docs/en/configure/shared.mdx
. These properties enhance control over shared module behavior.Experimental Features:
nodeModulesReconstructedLookup
experiment inapps/website-new/docs/en/configure/experiments.mdx
andpackages/enhanced/src/lib/container/ModuleFederationPlugin.ts
to improve module resolution for shared dependencies. [1] [2]Code Enhancements:
exclude
andinclude
options in theProvideSharedPlugin
to allow filtering shared modules by version or request. [1] [2]ProvideSharedPlugin
to encapsulate the logic for providing shared modules, improving maintainability. [1] [2]Testing Improvements:
test/compiler-unit/**/*.test.ts
inpackages/enhanced/jest.config.ts
andpackage.json
. This ensures the new features and configurations are thoroughly tested. [1] [2]Dependency Management:
@module-federation/cli
as a dependency inpackages/enhanced/package.json
to support CLI operations for the enhanced package. [1] [2]Related Issue
Types of changes
Checklist