feat(nextjs-mf): RSC Support #3736
Open
+70,434
−16,190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 5a946c4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 36 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for module-federation-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
ScriptedAlchemy
changed the title
ScriptedAlchemy
changed the title
ScriptedAlchemy
force-pushed
the
share-filter
branch
from
25626cf to
2ee38ff
Compare
ScriptedAlchemy
force-pushed
the
share-filter
branch
2 times, most recently
from
94b858a to
4bd1354
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
ScriptedAlchemy
changed the title
ScriptedAlchemy
force-pushed
the
pr9-implementation
branch
from
806abf2 to
217ba68
Compare
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Aug 8, 2025
ScriptedAlchemy
force-pushed
the
share-filter
branch
from
1fbe79b to
93507be
Compare
ScriptedAlchemy
force-pushed
the
pr9-implementation
branch
from
e90cbb9 to
d47ebc1
Compare
ScriptedAlchemy
force-pushed
the
share-filter
branch
from
93507be to
3d6dd83
Compare
ScriptedAlchemy
force-pushed
the
pr9-implementation
branch
from
d47ebc1 to
eac5e94
Compare
ScriptedAlchemy
force-pushed
the
share-filter
branch
from
3d6dd83 to
60d6549
Compare
ScriptedAlchemy
force-pushed
the
pr9-implementation
branch
from
c476e89 to
58442a7
Compare
ScriptedAlchemy
force-pushed
the
share-filter
branch
from
60d6549 to
055deac
Compare
ScriptedAlchemy
commented
Aug 13, 2025
ScriptedAlchemy
commented
Aug 13, 2025
INCREMENTAL_PR_PLAN_REVISED.md
Outdated
| @@ -0,0 +1,303 @@ | |||
| # Revised Incremental PR Plan for packages/enhanced Changes | |||
|
|
|||
There was a problem hiding this comment.
delete this file
ScriptedAlchemy
commented
Aug 13, 2025
packages/sdk/.swcrc
Outdated
| "type": "es6" | ||
| }, | ||
| "sourceMaps": true, | ||
| "inputSourceMap": false, |
There was a problem hiding this comment.
revert
Suggested change
| "inputSourceMap": false, | |
| "inputSourceMap": true, |
ScriptedAlchemy
commented
Aug 13, 2025
packages/sdk/rollup.config.cjs
Outdated
| if (Array.isArray(rollupConfig.output)) { | ||
| rollupConfig.output = rollupConfig.output.map((c) => ({ | ||
| ...c, | ||
| sourcemap: true, |
There was a problem hiding this comment.
revert
Suggested change
| sourcemap: true, | |
ScriptedAlchemy
commented
Aug 13, 2025
packages/sdk/rollup.config.cjs
Outdated
| } else { | ||
| rollupConfig.output = { | ||
| ...rollupConfig.output, | ||
| sourcemap: true, |
ScriptedAlchemy
commented
Aug 13, 2025
… 19.1.1 in all Next apps
- Map next/dist/compiled/react(*/)** to react(*/)** - Map next/dist/compiled/react-dom(*/)** to react-dom(*/)** - Add react/ and react-dom/ prefix shares to keep dev overlay on React 19 - Prevent React 18/19 mismatch causing useReducer null dispatcher crash in pages router dev overlay
- Disable DTS in modern.lib.config - Include types: chrome, react, react-dom; add skipLibCheck
- Map next/dist/compiled react* to installed react* - Add react*/ prefixes for overlay stability
Replace @nx/next executors with nx:run-commands in Next.js apps. Add NEXT_PRIVATE_LOCAL_WEBPACK=true to all commands. Remove @nx/next dependencies and withNx wrapper from configs. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Committed via Codex CLI on 2025-10-01
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant improvements to the Next.js App Router demo applications, enhances Module Federation integration, updates dependencies, and adds new CI/CD workflows and E2E test coverage. It also introduces a new React Module Federation host example and makes various configuration and workflow optimizations across the repository.
Next.js App Router and Module Federation Improvements:
4000and4001) to prepare for better React Server Components (RSC) support and upgraded dependencies to React 19 and Next.js 15.3.3. Improved configuration, dependency management, and build scripts for these demos. [1] [2]e2e-next-app-router.yml) to automate these tests. [1] [2] [3] [4]Dependency and Demo Application Updates:
3000-home,3001-shop,3002-checkout) to use React 19 and Next.js 15.3.3. Improved build and development scripts across all Next.js applications. [1] [2] [3] [4]CI/CD and Workflow Enhancements:
New Example Application:
apps/module-federation-react-example/host, including configuration files, a basic React app, and dynamic loading of remote components. [1] [2] [3] [4] [5] [6]Configuration and Miscellaneous Updates:
.cursorignoreto includedist/directories in version control..cursor/mcp.jsonand.cursorrulesfiles. [1] [2]Let me know if you want to dive deeper into any specific area or need help understanding how these changes affect your workflow!