Skip to content

Conversation

ScriptedAlchemy
Copy link
Member

  • Nx migrate to 21.5.3\n- Convert Jest configs to .cjs to avoid ESM loader issues\n- Strip comments from .swcrc before JSON.parse in configs\n- Re-add and run Jest v30 matcher migration

…st v30

- run nx migrate, install, run migrations
- convert jest configs to .cjs to avoid esm conflicts
- strip comments from .swcrc before json.parse
- restore and run jest v30 matcher migration
Copy link

changeset-bot bot commented Sep 25, 2025

⚠️ No Changeset found

Latest commit: e45ea47

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Sep 25, 2025

Deploy Preview for module-federation-docs failed. Why did it fail? →

Name Link
🔨 Latest commit 490db12
🔍 Latest deploy log https://app.netlify.com/projects/module-federation-docs/deploys/68d4c896424be500084d9b82

@ScriptedAlchemy ScriptedAlchemy changed the base branch from main to feat/apps-react-query-singleton-3000-3001 September 25, 2025 04:44
Copy link

💡 Codex Review

if (typeof val === 'string' || val === true || val === false) {
// Simple shared config – force pages-dir layer on the client/server compiler
out[key] =
val === false
? false

[P1] Preserve user-provided shared config when adding layer metadata

In addLayerToShared the branch that handles shorthand user entries (typeof val === 'string' || val === true) replaces the value with an object that only sets layer, issuerLayer, and allowNodeModulesSuffixMatch without carrying over the original semantics. If a user supplies shared: { react: '^18.2.0' } or true, the version requirement and default flags (singleton/eager) are discarded, so Module Federation will treat the share as unconstrained and may load incompatible versions at runtime. Consider copying the existing configuration (e.g. { requiredVersion: val } for strings and webpack’s default settings for true) before augmenting it with layer fields.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant