fix(esbuild): fix esbuild 0.25.0 compatibility and remote module loading #4255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3793678 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for module-federation-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
- Use esbuild context() API for watch mode (0.25.0 removed watch option) - Enables proper build and watch functionality in apps/esbuild demo 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Nsttt
force-pushed
the
Nsttt/test-esbuild-apps
branch
from
41b3cea to
57b0f91
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request addresses two critical issues in the esbuild integration: compatibility with esbuild 0.25.0's API changes and fixing remote module resolution to use runtime loading instead of import maps.
Key Changes:
- Updated build script to use esbuild's
context()API for watch mode instead of the deprecatedwatchoption - Refactored remote module loading to use
container.loadRemote()at runtime instead of relying on import maps
Reviewed changes
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
apps/esbuild/build/build-common.js |
Updated to use esbuild 0.25.0's context() API for watch mode, replacing the deprecated watch option in the build() call |
packages/esbuild/src/adapters/lib/linkRemotesPlugin.ts |
Refactored virtual module generation to use runtime loadRemote() instead of import maps, removed obsolete federationRemote/ resolution handler |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
The import map registration was failing because: 1. The runtimePlugin was looking for moduleMap in the host scope instead of fetching it from the remote module exports 2. The import map key was using the host name instead of the remote name 3. The async registration in runtimePlugin.init() ran after bootstrap imports This fix adds explicit synchronous import map registration in the host initialization code that runs after initializeSharing but before any code that imports from remotes. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
HaasStefan
added a commit
to HaasStefan/core
that referenced
this pull request
Dec 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed two critical issues preventing the
apps/esbuilddemo from working:1. esbuild 0.25.0 Watch Mode Compatibility
apps/esbuild/build/build-common.jswatchoption frombuild()APIesbuild.context()withctx.watch()for watch mode instead of passingwatchoption tobuild()2. Import Map Registration for ESM Remote Modules
packages/esbuild/src/adapters/lib/containerReference.tsmfe1/component) were failing with "Unable to resolve specifier" errorruntimePlugin.init()was looking formoduleMapin the host scope instead of fetching it from the remote module exportsruntimePlugin.init()ran after bootstrap imports needed theminitializeSharingbut before any code that imports from remotes. This ensures import maps are registered before es-module-shims tries to resolve remote module specifiers.Test Plan
pnpm nx run esbuild:buildcd apps/esbuild && pnpm run buildpnpm run start:remoteandpnpm run start:hostTypes of Changes
🤖 Generated with Claude Code