Repository navigation
Conversation
GET /api/tasks was subtracting 1 from the requested limit before using it as the SQL LIMIT, returning one fewer task than asked for. canDeleteTask also had its ownership comparison inverted, blocking owners from deleting their own tasks while allowing everyone else. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
AddTaskForm checked the untrimmed title before validating, so whitespace-only input slipped through as a valid task. TaskItem's toggle effect had an empty dependency array, so it only ever ran once on mount (immediately skipped by the first-render guard) and never fired the PATCH request on any checkbox click. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GET /api/tasks was subtracting 1 from the requested limit before using it as the SQL LIMIT, returning one fewer task than asked for. canDeleteTask also had its ownership comparison inverted, blocking owners from deleting their own tasks while allowing everyone else.