Skip to content

fix: resolve auth, pagination, and UI state bugs from Session 1 exercises #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
karawanshy wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: resolve auth, pagination, and UI state bugs from Session 1 exercises #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions app/api/tasks/route.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,7 @@ export async function GET(request: NextRequest) {
const offset = Number(searchParams.get('offset') ?? '0');

const where = projectId ? 'WHERE project_id = ?' : '';
const pageSize = limit - 1;
const params = projectId ? [Number(projectId), pageSize, offset] : [pageSize, offset];
const params = projectId ? [Number(projectId), limit, offset] : [limit, offset];

const tasks = db
.prepare(`SELECT * FROM Task ${where} ORDER BY created_at DESC LIMIT ? OFFSET ?`)
Expand Down
2 changes: 1 addition & 1 deletion components/AddTaskForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ export function AddTaskForm({ projectId }: AddTaskFormProps) {
event.preventDefault();

const trimmedTitle = title.trim();
if (!title) {
if (!trimmedTitle) {
setError('Title is required.');
return;
}
Expand Down
2 changes: 1 addition & 1 deletion components/TaskItem.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ export function TaskItem({ task }: TaskItemProps) {
headers: { 'Content-Type': 'application/json' },
body: JSON.stringify({ completed: completed ? 1 : 0 }),
}).then(() => router.refresh());
}, []);
}, [completed, router, task.id]);

return (
<li className="flex items-center gap-2">
Expand Down
2 changes: 1 addition & 1 deletion lib/task-authz.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import type { Task } from './types';

export function canDeleteTask(userId: number, task: Task): boolean {
return task.owner_id !== userId;
return task.owner_id === userId;
}