-
Notifications
You must be signed in to change notification settings - Fork 0
fix(server): resolve the premium prob err #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @mohit-nagaraj, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request addresses the issue of fetching premium problems when fetching the easy problem of the day. The changes involve modifying the GraphQL query to filter out premium problems and increasing the query limit to retrieve more problems. Specifically, the paidOnly
filter has been added to the query, and the query limit has been updated from 50 to 100 (although I don't see that change in the diffs provided). Additionally, the Problem
struct in types/types.go
has been updated to include the PaidOnly
field.
Highlights
- Filtering Premium Problems: The GraphQL query has been updated to include the
paidOnly: false
filter, ensuring that only non-premium problems are fetched. - Data Model Update: The
Problem
struct intypes/types.go
has been updated to include thePaidOnly
field to represent whether a problem is premium or not.
Changelog
- types/types.go
- Added the
PaidOnly
field to theProblem
struct to indicate whether a problem is premium.
- Added the
- utils/fetch.go
- Added the
paidOnly: false
filter to the GraphQL query to exclude premium problems. - Added
paidOnly
to the fields being queried in the GraphQL query.
- Added the
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
A bug in the code,
A premium problem arose,
Filter applied now,
Non-premium somehow,
The correct problem shows.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes the issue with fetching premium subscription problems by filtering out premium problems in the GraphQL query and reflects this change in the response type.
- Added the "paidOnly: false" filter and included "paidOnly" in the selection set of the query.
- Updated the Problem type to include the PaidOnly field.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
File | Description |
---|---|
utils/fetch.go | Added a filter to exclude premium problems and updated the response fields. |
types/types.go | Added the PaidOnly field to match the query changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request aims to resolve the issue of fetching premium problems when fetching the easy problem of the day. The changes include adding a filter to exclude premium problems and increasing the query limit. Overall, the changes seem reasonable and address the intended issue.
Summary of Findings
- Missing Error Handling: The code lacks error handling for the
resp.Body.Close()
calls inutils/fetch.go
. While deferred, it's good practice to handle potential errors, even if it's just logging them. - Magic Number: The date
2025, 3, 29
is used as a start date to calculate the index of the problem. It would be better to define this as a constant with a descriptive name to improve readability and maintainability.
Merge Readiness
The pull request addresses the intended issue and the changes seem reasonable. However, addressing the missing error handling and the magic number would improve the code quality. I am unable to directly approve the pull request, and other reviewers should review and approve this code before merging.
Description
This pull request addresses the issue of fetching premium subscription problems in the
FetchEasyProblemOfTheDay
function. The following changes have been made:Added Filter to Exclude Premium Problems:
paidOnly: false
filter to ensure only non-premium problems are fetched.Increased Query Limit:
Issue Reference
Fixes #6
Testing
FetchEasyProblemOfTheDay
function to ensure it fetches only non-premium problems and works as expected with the updated limit.