Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add remove method to return Option<V> for unsync cache (v0.11.x branch) #48

Merged
merged 2 commits into from
Jan 12, 2025

Conversation

tatsuya6502
Copy link
Member

On #43, @JokerXiL said:

With current implementation of unsync cache, it is possible for the invalidate method to return previous cached value.

I modified it and put it as new remove method.

In order to merge the stuff for #43 into the current active branch v0.11.x, I created a new branch from v0.11.x branch and ran git cherry-pick 7cad7fd44afd61a09df18b3c0b7bb4eb63e14faf to take the commit.

@tatsuya6502 tatsuya6502 added this to the v0.11.0 milestone Jan 12, 2025
@tatsuya6502 tatsuya6502 marked this pull request as ready for review January 12, 2025 11:46
Copy link
Member Author

@tatsuya6502 tatsuya6502 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging.

@tatsuya6502 tatsuya6502 merged commit 1ecd8f3 into v0.11.x Jan 12, 2025
24 checks passed
@tatsuya6502 tatsuya6502 deleted the add-remove-method branch January 12, 2025 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants