fix: run tests before version bump in release workflow#3
Merged
regevguym merged 1 commit intomondaycom:mainfrom Mar 19, 2026
Merged
fix: run tests before version bump in release workflow#3regevguym merged 1 commit intomondaycom:mainfrom
regevguym merged 1 commit intomondaycom:mainfrom
Conversation
- Move build + test steps before version bump so tests run against the current version (not the bumped one) - Make CLI --version test read expected version from package.json instead of hardcoding it, so it stays correct across bumps Closes mondaycom#2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The release workflow bumps package versions before running tests. The CLI test has a hardcoded version assertion (
0.0.1), so after bump it fails:From failed run #23291937157.
Fix
--versiontest dynamic — reads expected version frompackage.jsoninstead of hardcodingChanges
.github/workflows/release.yml— reorder steps: install → build → test → validate → bump → publishpackages/cli/tests/cli.test.ts— read version frompackage.jsondynamicallyCloses #2