docs(Dropdown): Searchable single select page (current implementation)#3406
Open
rivka-ungar wants to merge 4 commits into
Open
docs(Dropdown): Searchable single select page (current implementation)#3406rivka-ungar wants to merge 4 commits into
rivka-ungar wants to merge 4 commits into
Conversation
…tion) Adds the same Searchable single select stories and accessibility page as the fix branch, on a branch off master, so the identical examples can be compared against the current implementation. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
Code Review by Qodo
1.
|
Contributor
PR Summary by Qododocs(Dropdown): Add searchable single-select Storybook page for current impl WalkthroughsDescription• Add Storybook MDX accessibility page for searchable single-select Dropdown examples. • Introduce a matching stories suite to compare current vs fix-branch rendering. • Touch SingleSelectTrigger with a comment to ensure Chromatic publishes preview builds. Diagramgraph TD
A["MDX docs page"] --> B["Stories (TSX)"] --> C["Storybook build"] --> D["Dropdown component"] --> E["SingleSelectTrigger"]
C --> F{{"Chromatic preview"}}
High-Level AssessmentThe following are alternative approaches to this PR: 1. Feature-flag the trigger behavior and document both modes in one Storybook
2. Keep docs only on the fix branch and rely on Chromatic baseline comparisons
3. Create a single story that demonstrates both renderings via controlled props/mocks
Recommendation: For a short-lived, reviewer-focused before/after comparison, duplicating the example set on a master-based branch is a pragmatic approach because it isolates rendering differences to the component implementation. If these docs are expected to persist, prefer a single Storybook with a temporary feature flag or an explicit A/B story to avoid ongoing duplication and drift. File ChangesDocumentation (3)
|
![qodo-free-for-open-source-projects[bot]](https://avatars.githubusercontent.com/in/1068000?s=60&v=4){kind=small}
Keep the same examples and section titles but remove the descriptive prose and in-story captions that describe the new (fix-branch) behavior, so this master-based page just shows the current dropdowns for comparison. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
Code Review by QodoNew Review StartedThis review has been superseded by a new analysis |
Keep only the five examples the new page documents (Overview, default value, icons & avatars, end elements, valueRenderer); remove the extra examples so the two pages line up one-to-one for comparison. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
|
Code review by qodo was updated up to the latest commit ea3ee33 |
Touches @vibe/core so CI detects a package change and publishes the Chromatic Storybook preview for the docs examples. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
|
Code review by qodo was updated up to the latest commit 7a706d3 |
Contributor
|
📦 Bundle Size Analysis ✅ No bundle size changes detected. Unchanged Components
📊 Summary:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Adds the same Searchable single select stories and accessibility page that exist on the fix branch (
fix/single-searchable-dropdown-a11y-selected-value), but on a branch off master with the current component implementation unchanged.This lets us deploy/compare the identical examples on two branches:
The story files are byte-identical to the fix branch, so any rendering difference between the two Storybooks is due solely to the component change, making the before/after easy to compare.
Note
This branch contains only the docs/stories — no component changes. The page's prose describes the target behavior; the live examples render the current implementation, which is exactly the comparison point.
🤖 Generated with Claude Code