BAAS-35403 add lock to runtime maxStackObjectMemUsage#133
Merged
Conversation
Gabri3l
reviewed
Apr 14, 2025
|
|
||
| func (r *Runtime) setMaxStackObjectMemUsage(mem uint64) { | ||
| r.maxStackObjectMemLock.Lock() | ||
| r.maxStackObjectMem = mem |
There was a problem hiding this comment.
Logic here is a bit different, not sure it makes a difference (e.g. not using math.Max)
Author
There was a problem hiding this comment.
yep, just using this as a setter here! And used a logical check over Math.max elsewhere to reduce the number of times we call into this to get the lock
Gabri3l
approved these changes
Apr 14, 2025
Gabri3l
left a comment
Gabri3l
left a comment
There was a problem hiding this comment.
Besides one comment this looks good, hopefully no/low perf impact.
Author
Yep good callout. I ran the benchmarks and the impact of the lock was negligible here so that's good |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.