Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump mongodb-log-writer MONGOSH-1992 #6634

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gagik
Copy link

@gagik gagik commented Jan 20, 2025

Includes a version bump and adjustments for the breaking change from the latest major release.

Related to mongodb-js/devtools-shared#498

Includes a version bump and adjustments for the breaking change from the latest major release.
@gagik gagik changed the title chore: bump mongodb-log-writer chore(deps): bump mongodb-log-writer Jan 20, 2025
@gagik gagik changed the title chore(deps): bump mongodb-log-writer chore(deps): bump mongodb-log-writer MONGOSH-1992 Jan 20, 2025
Copy link
Collaborator

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it matter whether this is bundled with the corresponding shell updates?

@gagik
Copy link
Author

gagik commented Jan 20, 2025

@addaleax I imagine it wouldn't? We may end up having two versions as the dependencies (this is the case because of the oidc-plugin right now looking at package-lock, though I don't know if this means we're fully bundling both) but don't think it'd be anything problematic functionality wise. Hopefully caught by the tests if I'm wrong.

Copy link
Collaborator

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gagik Yeah, probably just a bit of unnecessary paranoia on my end around making sure our dependencies are on the same version 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants