Skip to content

feat(data-modeling): integrate diagramming package COMPASS-9357 #6979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 35 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
0bfc7fc
diagramming
mabaasit May 26, 2025
0a52b02
diagramming
mabaasit May 26, 2025
9f866ee
edges
paula-stacho May 27, 2025
81d011e
Merge branch 'main' of https://github.com/mongodb-js/compass into dia…
mabaasit May 27, 2025
e427663
npm install
mabaasit May 27, 2025
e2b01c7
remove relationship
mabaasit May 28, 2025
37f2a0a
correct type
mabaasit Jun 2, 2025
26f3993
Merge branch 'diagramming' of https://github.com/mongodb-js/compass i…
mabaasit Jun 2, 2025
acb4084
bootstrap
mabaasit Jun 2, 2025
46f7f38
Merge branch 'main' of https://github.com/mongodb-js/compass into dia…
mabaasit Jun 2, 2025
fea7bf4
no lock changes
mabaasit Jun 2, 2025
0c3d611
npm i
mabaasit Jun 2, 2025
599fbdd
main lock file
mabaasit Jun 2, 2025
17601c2
checkout lock from main
mabaasit Jun 2, 2025
6a377af
npm install
mabaasit Jun 2, 2025
59381eb
add todo and show cardinality
mabaasit Jun 2, 2025
bba2841
npm run check
mabaasit Jun 2, 2025
5a8b59e
Merge branch 'main' into diagramming
mabaasit Jun 2, 2025
de016d6
update diagramming
mabaasit Jun 5, 2025
74b8119
bump package
mabaasit Jun 11, 2025
220cab3
bump package
mabaasit Jun 11, 2025
78f1d5f
undo webpack changes
mabaasit Jun 11, 2025
b085827
missing importexports warning
mabaasit Jun 11, 2025
f0da710
Merge branch 'main' of https://github.com/mongodb-js/compass into dia…
mabaasit Jun 11, 2025
1aa7fbc
npm i
mabaasit Jun 11, 2025
0e16a8f
Merge branch 'main' into diagramming
mabaasit Jun 11, 2025
1d3464d
fix tests
mabaasit Jun 12, 2025
252478a
Merge branch 'main' of https://github.com/mongodb-js/compass into dia…
mabaasit Jun 12, 2025
bf8ae07
npm i
mabaasit Jun 12, 2025
5bd2b98
fix dev version
mabaasit Jun 12, 2025
dcfc6f2
correct func name
mabaasit Jun 12, 2025
bed5629
clean up tests
mabaasit Jun 12, 2025
49e8269
Merge branch 'main' of https://github.com/mongodb-js/compass into dia…
mabaasit Jun 12, 2025
62b4de2
npm i
mabaasit Jun 12, 2025
b392d15
clean up
mabaasit Jun 12, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .evergreen/print-compass-env.sh
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,8 @@ if [[ "${EVERGREEN_PROJECT}" == "10gen-compass-main" ]]; then
month=$(escapeLeadingZero "${ts[1]}")
day=$(escapeLeadingZero "${ts[2]}")
hour=$(escapeLeadingZero "${ts[3]}")
minute="${ts[4]}"
second="${ts[5]}"
minute=$(escapeLeadingZero "${ts[4]}")
second=$(escapeLeadingZero "${ts[5]}")
Comment on lines +46 to +47
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small drive-by because CI failed for this PR in this run.

When hour is 00 and minutes < 10, the version is as yymmdd-dev.0.., which is invalid

export DEV_VERSION_IDENTIFIER="${year}.${month}.${day}-dev.${hour}${minute}${second}"
fi
fi
Expand Down
21 changes: 21 additions & 0 deletions configs/webpack-config-compass/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,17 @@ export function createElectronMainConfig(
sharedObjectLoader(opts),
sourceLoader(opts),
],
parser: {
javascript: {
// Webpack compile time check for imports matching exports is too strict
// in cases where the code expects some name export to be optional
// (webpack will break the build if it fails to statically see the
// matching export) this is why we switch the check to just warn. If
// this ever hides a real case where a missing import is being used, it
// will definitely break in runtime anyway
importExportsPresence: 'warn' as const,
},
},
},
node: false as const,
externals: toCommonJsExternal(sharedExternals),
Expand Down Expand Up @@ -218,6 +229,11 @@ export function createElectronRendererConfig(
sharedObjectLoader(opts),
sourceLoader(opts),
],
parser: {
javascript: {
importExportsPresence: 'warn' as const,
},
},
},
plugins: [
...entriesToHtml(entries),
Expand Down Expand Up @@ -338,6 +354,11 @@ export function createWebConfig(args: Partial<ConfigArgs>): WebpackConfig {
assetsLoader(opts),
sourceLoader(opts),
],
parser: {
javascript: {
importExportsPresence: 'warn' as const,
},
},
},
// This follows current Compass plugin behavior and is here more or less to
// keep compat for the external plugin users
Expand Down
Loading
Loading