feat(workspaces): context menu on tabs to duplicate and close all other tabs #7053
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gribnoysup
reviewed
Jun 27, 2025
| dispatch({ type: WorkspacesActions.CloseTab, atIndex }); | ||
| cleanupLocalAppRegistryForTab(tab?.id); | ||
| dispatch({ type: WorkspacesActions.CloseAllOtherTabs, atIndex }); | ||
| cleanupLocalAppRegistryForTab(tabs[atIndex].id); |
There was a problem hiding this comment.
You want to cleanup for tabs that you closed, not for the only one that stays open. We usually do this through cleanupRemovedTabs method used in similar cases in this slice
gribnoysup
reviewed
Jun 27, 2025
| const { tabs } = getState(); | ||
| const otherTabs = tabs.filter((_, index) => index !== atIndex); | ||
| for (const tab of otherTabs) { | ||
| if (!canCloseTab(tab) && !(await confirmClosingTabs())) { |
There was a problem hiding this comment.
Doesn't feel right that canceling close for one tab stops all the others from closing too (or the other way around, you say "yes" for one, then "no" for other, and all stay open), in vscode you'd be asked for evey one separately and they are closed based on your answers. Wouldn't that make more sense for our flow too?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Merging this PR will:
tabs-context-menu.mov
Checklist
Motivation and Context
Open Questions
I feel the tooltip is getting in the way of this interaction and while we could solve this in a bespoke way (ex disabling the tooltip component if the context menu
isOpen), we could disable the underlying UI (using ex thepointer-eventsCSS property) when the menu is in its opened state.Dependents
Types of changes