refactor(storage): refactor CompassQueryStorage to accept storage backend rather than userData COMPASS-9489 #7058
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gribnoysup
reviewed
Jun 27, 2025
Comment on lines
+98
to
+99
| // will throwing Errors here be bubbled up properly? | ||
| // or should I return undefined or null? |
There was a problem hiding this comment.
UserData and dependant services allow to use "update" as "create" in cases where the item doesn't exist yet, so this shouldn't throw
gribnoysup
reviewed
Jun 27, 2025
| await this.userData.write(id, updated as z.input<TSchema>); | ||
| const after = await this.readOne(id); | ||
| if (!after) { | ||
| throw new Error(`Failed to update record for id ${id}`); |
There was a problem hiding this comment.
Similarly we usually don't throw from these when write failed. Generally speaking I'd suggest to align with the current behavior of those without changing it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes