chore(e2e): refactor resize into its own method; use compass default instead of os max screen size #7545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…instead of os max screen size
lerouxb
approved these changes
Nov 10, 2025
Anemy
approved these changes
Nov 10, 2025
gribnoysup
added
the
no-title-validation
Collaborator
Author
|
Okay, I think smokes are passing now, the failing ones are due to macos-13 hosts deprecation in github actions. I'll merge this and keep an eye on the main waterfall |
gribnoysup
deleted the
e2e-use-consistent-window-size-based-on-compass-default
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screen size on CI hosts we have seems to be inconsistent and because we're setting screen size based on the machine max screen size, sometimes Compass window is smaller than even our default allowed window min size. To try to make sure that all tests are executed against the app in the same state, I'm changing the logic to use default window size instead of maximizing.
We're not sure this will work on all hosts, so first opening as a draft just to see what happens in CI