feature/COMPASS-9432 Use measured heights or calculate #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lchans
approved these changes
Jun 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
External Links
Description
We use
node.measured.width|height(see interface BaseNode).elkjslibrary uses top levelnode.width|height. InapplyLayout, we've been ignoring themeasuredvalues and expecting the top level ones, creating an unexpected inconsistency.This is already used in the migrator, so I'm keeping the top level dimensions to avoid a breaking change.
The other change is, if the measured values will not be provided, the function will apply defaults. I see this as the preferred way, as it keeps the separation of knowledge (the client doesn't need to know about default node styles).
Notes for Reviewers
📸 Screenshots/Screencasts
Before
After