fix: roll back node-abi until lgeiger/node-abi#90 is resolved #118
Conversation
emadum
changed the title
| "version": "2.19.1", | ||
| "resolved": "https://registry.npmjs.org/node-abi/-/node-abi-2.19.1.tgz", | ||
| "integrity": "sha512-HbtmIuByq44yhAzK7b9j/FelKlHYISKQn0mtvcBrU5QBkhoCMp5bu8Hv5AI34DcKfOAcJBcOEMwLlwO62FFu9A==", | ||
| "version": "2.18.0", |
There was a problem hiding this comment.
Where is the change to package.json? We should pin the version there, not just the lock file
There was a problem hiding this comment.
We don't depend on it directly, it's a dependency of prebuild.
There was a problem hiding this comment.
is it not possible to explicitly pin it in our package.json even if its a transient dependency? I'm concerned that the next time someone runs npm install it will "fix" this and revert your change
There was a problem hiding this comment.
It's certainly possible to add it to our package.json but I don't think it's necessarily the correct solution since it's not a direct dependency. Regarding your concern, subsequent npm installs should pull the version from package-lock.json, someone would have to delete the current package-lock.json before running an npm install, or explicitly run npm install node-abi@latest, in order to update the version in the lock file.
I'd also hope the underlying issue with node-abi will be resolved by then.
Description
electron/node-abi#90 currently breaks our prebuilds, this PR rolls it
back to a working version directly in the
package-lock.jsonas atemporary fix until the issue is resolved.
What changed?