Skip to content

feat(NODE-7216)! remove support for enableMultipleCollInfo #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 30, 2025
Merged

feat(NODE-7216)! remove support for enableMultipleCollInfo #101

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6a39cda
remove support for enableMultipleCollInfo
baileympearson Sep 26, 2025
de53752
fix lint
baileympearson Sep 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions addon/mongocrypt.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -585,10 +585,7 @@ MongoCrypt::MongoCrypt(const CallbackInfo& info) : ObjectWrap(info) {

mongocrypt_setopt_retry_kms(mongo_crypt(), true);

if (options.Get("enableMultipleCollinfo").ToBoolean()) {
/** TODO(NODE-6793): remove this option and have it always set in the next major */
mongocrypt_setopt_enable_multiple_collinfo(mongo_crypt());
}
mongocrypt_setopt_enable_multiple_collinfo(mongo_crypt());

// Initialize after all options are set.
if (!mongocrypt_init(mongo_crypt())) {
Expand Down
6 changes: 2 additions & 4 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,12 +69,10 @@
bypassQueryAnalysis?: boolean;
/** Configure the time to expire the DEK from the cache. */
keyExpirationMS?: number;
/** TODO(NODE-6793): remove this option and have it always set in the next major */
enableMultipleCollinfo?: boolean;
};

export interface MongoCryptConstructor {
new (options: MongoCryptConstructorOptions): MongoCrypt;
new(options: MongoCryptConstructorOptions): MongoCrypt;

Check failure on line 75 in src/index.ts

View workflow job for this annotation

GitHub Actions / typescript 

Insert `·`
libmongocryptVersion: string;
}

Expand Down Expand Up @@ -137,6 +135,6 @@

/** exported for testing only. */
interface MongoCryptContextCtor {
new (): MongoCryptContext;
new(): MongoCryptContext;

Check failure on line 138 in src/index.ts

View workflow job for this annotation

GitHub Actions / typescript 

Insert `·`
}
export const MongoCryptContextCtor: MongoCryptContextCtor = mc.MongoCryptContextCtor;
Loading