-
Notifications
You must be signed in to change notification settings - Fork 150
chore: update atlas tools output to json - MCP-264 #653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
blva
wants to merge
18
commits into
main
Choose a base branch
from
MCP-264
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 18911327516Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates Atlas tools to return JSON-formatted data instead of table-formatted output, improving machine readability and consistency.
Key Changes:
- Replaced table-formatted output with JSON.stringify() for all Atlas tool responses
- Updated integration tests to validate JSON content instead of parsing tables
- Removed unused table parsing utility function
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/tools/atlas/read/listOrgs.ts | Converts organization list output from table to JSON format |
| src/tools/atlas/read/listDBUsers.ts | Converts database users output from table to JSON, removes helper functions |
| src/tools/atlas/read/listClusters.ts | Converts cluster list output from table to JSON for both all-projects and single-project views |
| src/tools/atlas/read/listAlerts.ts | Converts alerts output from table to JSON format |
| src/tools/atlas/read/inspectCluster.ts | Converts cluster details output from table to JSON format |
| src/tools/atlas/read/inspectAccessList.ts | Converts access list entries output from table to JSON format |
| tests/integration/tools/atlas/orgs.test.ts | Updates test to validate JSON content instead of parsing tables |
| tests/integration/tools/atlas/clusters.test.ts | Updates tests to validate JSON content, removes table parsing logic |
| tests/integration/tools/atlas/alerts.test.ts | Updates test description and assertions to expect JSON format |
| tests/integration/tools/atlas/atlasHelpers.ts | Removes unused parseTable helper function |
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Checklist