chore(ci): move releasing to GitHub Actions MONGOSH-1871 #2309
Conversation
gagik
force-pushed
the
gagik/move-release-ga
branch
from
0edc03e to
187cfd2
Compare
| name: Release mongosh | ||
| on: | ||
| workflow_run: | ||
| workflows: ["CheckQL", "Run Smoke Tests", "evergreen"] |
There was a problem hiding this comment.
I am not sure if evergreen is considered a workflow since it seems to be created by a bot/integration(?). Could leave and see what happens or just make it manual-only
gagik
force-pushed
the
gagik/move-release-ga
branch
from
187cfd2 to
8bfe843
Compare
gagik
force-pushed
the
gagik/individual-publishing
branch
3 times, most recently
from
3c557da to
68e3e62
Compare
gagik
force-pushed
the
gagik/move-release-ga
branch
from
8bfe843 to
707000e
Compare
|
Super general note, but if we move triggering mongosh product releases out of Evergreen, we probably also need to adjust our papertrail integration like we do in Compass (where we write the name of the releaser into Compass's package.json, commit it, push it, and then retrieve it when Evergreen pushes the release: https://github.com/mongodb-js/compass/blob/0ca8439b07c31f406fda74c5a0340de1353d9915/.evergreen/compass_package.sh#L21-L59) |
gagik
force-pushed
the
gagik/individual-publishing
branch
2 times, most recently
from
ed9ffa1 to
e2ceaa5
Compare
gagik
force-pushed
the
gagik/move-release-ga
branch
2 times, most recently
from
7868a6c to
990f8ee
Compare
gagik
changed the title
| ['merge', '--squash', `origin/release/${mongoshVersion}`], | ||
| commandOptions | ||
| ); | ||
| spawnSync( |
There was a problem hiding this comment.
I guess this essentially merges the PR but wondering if it'd be worth using GitHub CLI here instead to i.e. have reference to the original PR naming when merging. Don't know how easy it is with how our GitHub Actions Bot token works
There was a problem hiding this comment.
Yeah, right now this pushes from evergreen, right? Do we even have permissions for that?
There was a problem hiding this comment.
Depends on the token - the devtools bot token does have permissions for that, but I'd really like to avoid pushing to main if there's an open PR we could merge.
There was a problem hiding this comment.
Hm. We can either make the merging of the PR manual, based on a cron job like in Compass, or try to set it up in evergreen, i.e. install the GitHub CLI inside evergreen and then use GITHUB_TOKEN (not sure what permissions this is) to merge the created PR.
Actually what I could do is to create a GitHub workflow which gets triggered on release tag push and merge the PR from there!
| { isDryRun = false, useAuxiliaryPackagesOnly = false }, | ||
| listNpmPackages: typeof listNpmPackagesFn = listNpmPackagesFn, |
There was a problem hiding this comment.
getting rid of this helper so we can share more code
| ['merge', '--squash', `origin/release/${mongoshVersion}`], | ||
| commandOptions | ||
| ); | ||
| spawnSync( |
There was a problem hiding this comment.
Yeah, right now this pushes from evergreen, right? Do we even have permissions for that?
gagik
force-pushed
the
gagik/move-release-ga
branch
2 times, most recently
from
d741f6a to
3bd3cae
Compare
Co-authored-by: Nikola Irinchev <[email protected]>
gagik
force-pushed
the
gagik/move-release-ga
branch
from
3bd3cae to
6aa5223
Compare
gagik
force-pushed
the
gagik/move-release-ga
branch
from
6aa5223 to
e880d36
Compare
…d testing This ended up being a larger refactor than intended but it was getting increasingly difficult to add new helpers and test them with the current setup. Now, instead of passing all helpers as spies, they exist as properties on "Publisher" objects which makes them easier to stub them with sinon.
Built on top of #2289.
To Do: