fix(cli-repl): account for Node.js 24 multi-line REPL handling update MONGOSH-2233 #2482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
commented
Jun 23, 2025
| { | ||
| // Regression test for MONGOSH-2233, included here because multiline support is a bit | ||
| // more fragile when it comes to newer Node.js releases and these are the only tests | ||
| // that run as part of the homebrew setup. |
There was a problem hiding this comment.
Worth mentioning that our regular test suite does catch this (when run against Node.js 24, so we should add that to our CI soon too), we just don't run the relevant tests in homebrew.
lerouxb
reviewed
Jun 23, 2025
lerouxb
approved these changes
Jun 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still needs tests, but I think I got close to the bottom of this and this patch should resolve this issue. Opening a PR already to see what CI says.