Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow device auth flow without id_token MONGOSH-1669 #187

Merged
merged 14 commits into from
Feb 7, 2024
Merged

fix: allow device auth flow without id_token MONGOSH-1669 #187

merged 14 commits into from
Feb 7, 2024

Conversation

paula-stacho
Copy link
Contributor

@paula-stacho paula-stacho commented Feb 2, 2024 •
edited
Loading

https://jira.mongodb.org/browse/MONGOSH-1669

New logic:

  • it is possible to complete a device auth flow without id_token (with a warning)
  • this is only allowed as long as the id_token is consistently not included (errors are thrown if the presence/absence is unexpected based on the previous token set)

addaleax
addaleax reviewed Feb 5, 2024
View reviewed changes
addaleax
addaleax reviewed Feb 6, 2024
View reviewed changes
@paula-stacho paula-stacho marked this pull request as ready for review February 6, 2024 14:11
@paula-stacho paula-stacho merged commit 6bef820 into main Feb 7, 2024
18 of 20 checks passed
@paula-stacho paula-stacho deleted the MONGOSH-1669 branch February 7, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paula-stacho @addaleax