feat!(deps): bump driver to 6.7.0 MONGOSH-1790 #191
Conversation
addaleax
changed the title
| @@ -74,7 +74,7 @@ | |||
| "gen-esm-wrapper": "^1.1.0", | |||
| "husky": "^8.0.3", | |||
| "mocha": "^10.2.0", | |||
| "mongodb": "^5.4.0", | |||
| "mongodb": "^6.7.0", | |||
There was a problem hiding this comment.
This is already close to the maximal breaking change we could do for this work, we might as well remove abort-controller too.
There was a problem hiding this comment.
you mean our OIDCAbortSignal, right?
There was a problem hiding this comment.
No – I mean abort-controller 🙂
There was a problem hiding this comment.
ah, i noticed it in deps! will remove it
src/types.ts
Outdated
| timeoutSeconds?: number; | ||
| timeoutContext?: OIDCAbortSignal; | ||
| version: number; | ||
| timeoutContext: OIDCAbortSignal; |
There was a problem hiding this comment.
| timeoutContext: OIDCAbortSignal; | |
| timeoutContext?: OIDCAbortSignal; |
Or is there a specific reason why this needs to be required?
There was a problem hiding this comment.
driver has marked it as required prop. if we don't have to align this bit, i'll leave it as optional
There was a problem hiding this comment.
We can always be more accepting than the driver
src/plugin.spec.ts
Outdated
| abortSignal?: OIDCAbortSignal | ||
| ): ReturnType<OIDCCallbackFunction> { | ||
| return plugin.mongoClientOptions.authMechanismProperties.OIDC_HUMAN_CALLBACK({ | ||
| timeoutContext: abortSignal ?? new AbortController().signal, |
There was a problem hiding this comment.
| timeoutContext: abortSignal ?? new AbortController().signal, | |
| timeoutContext: abortSignal, |
No description provided.