chore: use erasable syntax #1175
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now, we should definetely adopt erasable syntax but this is a bit too much refactoring right now so this quick fix will do.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR disables the experimental strip types feature in Node.js to fix failing tests. The change adds the --no-experimental-strip-types flag to the test-webview script while also adding new MongoDB syntax highlighting for similarity operators ($similarityCosine, $similarityDotProduct, $similarityEuclidean) and the $scoreFusion operator.
- Disables experimental strip types feature for webview tests
- Adds syntax highlighting support for MongoDB similarity operators
- Adds syntax highlighting support for MongoDB
$scoreFusionoperator
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| package.json | Adds --no-experimental-strip-types flag to test-webview script to disable the experimental feature |
| syntaxes/mongodbInjection.tmLanguage.json | Adds TextMate grammar rules for MongoDB similarity operators and score fusion operator |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
gagik
commented
Nov 4, 2025
| } | ||
| }, | ||
| { | ||
| "name": "meta.object.member.mongodb", |
Contributor
Author
There was a problem hiding this comment.
seems like some auto-generated that was missed from previous PRs
gagik
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I admit this went out of hand, originally I thought erasable syntax will be just a couple of enums being converted to consts.
Then I noticed we use a lot of enums.
Then I noticed half of scripts use CJS-specific things.
Then I realized configuring mocha properly to use this erasable syntax is too complicated... so we still use
ts-nodefor that, a shame 😢Still, having less ts-node is cool. 🤷