Skip to content

chore: Onboard to Silkbomb to generate SSDLC reports, SBOM and generate augmented SBOM on demand #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 20, 2025

Conversation

oarbusi
Copy link
Contributor

@oarbusi oarbusi commented Jun 18, 2025

Description

Link to any related issue(s): CLOUDP-325296

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR. A migration guide must be created or updated if the new feature will go in a major version.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR. A migration guide must be created or updated.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contributing guides
  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • If changes include deprecations or removals I have added appropriate changelog entries.
  • If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Further comments

@oarbusi oarbusi marked this pull request as ready for review June 18, 2025 15:08
@Copilot Copilot AI review requested due to automatic review settings June 18, 2025 15:08
@oarbusi oarbusi requested a review from a team as a code owner June 18, 2025 15:08
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR onboards Silkbomb for SSDLC and SBOM generation by adding a suite of compliance scripts, updating the Makefile targets, and enhancing GitHub workflows to support both standard and augmented report generation.

  • Introduces new compliance scripts for generating SBOM, PURLs, and SSDLC compliance reports.
  • Updates Makefile with additional phony targets to integrate these scripts into the build process.
  • Modifies GitHub workflows to automate SBOM upload and SSDLC report generation.

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.

Show a summary per file
File Description
templates/ssdlc-compliance.template.md New Markdown template for SSDLC compliance reporting.
scripts/compliance/upload-sbom.sh Script for uploading SBOM using Docker.
scripts/compliance/gen-ssdlc-report.sh Script to generate SSDLC reports with conditional augmented report.
scripts/compliance/gen-sbom.sh Script to generate SBOM using Docker.
scripts/compliance/gen-purls.sh Script to generate PURLs from Go binaries across multiple OS platforms.
scripts/compliance/extract-purls.sh Helper script to extract package information from Go binaries.
scripts/compliance/augment-sbom.sh Script to augment the SBOM with additional repository branch detail.
Makefile Updated with new phony targets for compliance-related scripts.
.github/workflows/release.yml Modified to include a compliance job for SBOM upload and SSDLC report generation.
.github/workflows/generate-augmented-sbom.yml New workflow to run the augmented SBOM generation and report creation.

KONDUKTO_BRANCH_PREFIX: ${{ vars.KONDUKTO_BRANCH_PREFIX }}
SILKBOMB_IMG: ${{ vars.SILKBOMB_IMG }}
steps:
- uses: actions/checkout@v4
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SHA in all GHA

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done! I keep copy pasting the same (wrong) actions

GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

generate-ssdlc-report:
needs: compliance
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can i depends on release on needs something from compliance?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ssdlc report references sbom.json uploaded in the compliance step, so depends on compliance step

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, similar to question in another PR, is it better in different jobs or steps in the same job?

@oarbusi oarbusi merged commit d34a3dd into main Jun 20, 2025
7 checks passed
@oarbusi oarbusi deleted the CLOUDP-325296 branch June 20, 2025 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants