This repository has been archived by the owner on Nov 8, 2023. It is now read-only.
DEVHUB-1938 pulling original publish date from publish metadata colle… #645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcolella14
approved these changes
Oct 31, 2023
| @@ -26,7 +70,7 @@ export const CS_getArticleBySlugFromCMS = async ( | |||
| client, | |||
| variables | |||
| )) as CS_ArticleResponse[]; | |||
|
|
|||
| await CS_adjustOriginalPublishDate(client, calculatedSlug, articles); | |||
There was a problem hiding this comment.
Do we have a sense of how this will affect page speed? Seems like fetching both all articles and all publish metadata might add some time.
There was a problem hiding this comment.
it will add some time - let me check the metrics -
there are 2 other options
- get from preval - which might be stale
- combine the graphql query - like a join
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pulling original publish date from publish metadata collection
https://jira.mongodb.org/browse/DEVHUB-1938
Backend PR : https://github.com/10gen/devcenter-backend/pull/127
A new collection "Publish Metadata" is created in contentstack which will store the publish date of the article when published from "ContentStack". There is a realm webhook to create metadata entry upon publishing which needs to be migrated later as captured in https://jira.mongodb.org/browse/DEVHUB-1938