Skip to content

Conversation

@WaVEV
Copy link
Collaborator

@WaVEV WaVEV commented Oct 21, 2025

This increases the test coverage for query refactor (#396).

@WaVEV WaVEV force-pushed the direct-query-lookup-tests branch 4 times, most recently from 9bf4025 to 804b0c0 Compare October 27, 2025 21:19
@WaVEV WaVEV force-pushed the direct-query-lookup-tests branch 2 times, most recently from 6ee279f to 1c6e93d Compare October 29, 2025 23:43
@WaVEV WaVEV marked this pull request as ready for review October 31, 2025 22:38
@timgraham
Copy link
Collaborator

What do you mean by "direct query"? The specific importance of these tests isn't clear to me. I'm not opposed to adding them, just trying to understand the motivation of the follow up.

@WaVEV
Copy link
Collaborator Author

WaVEV commented Nov 14, 2025

What do you mean by "direct query"? The specific importance of these tests isn't clear to me. I'm not opposed to adding them, just trying to understand the motivation of the follow up.

When I say "direct query", that is just a name I came up with to describe the code path that uses a plain match instead of $expr. it’s just how I’ve been referring to that part of the compiler.

When I refactored the $lookup logic in a previous PR, some tests were postponed to be added later. So the motivation here is simply to add unit tests to increase coverage for this “new” way of querying.

@WaVEV WaVEV force-pushed the direct-query-lookup-tests branch from 7bcc842 to e6fbc1c Compare November 14, 2025 01:26
@timgraham timgraham changed the title Direct query lookup tests Add more path lookup tests Nov 14, 2025
@timgraham timgraham merged commit 64c03ca into mongodb:main Nov 14, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants