DOCSP-48400-confusion-multi-shard-key #732
Conversation
✅ Deploy Preview for docs-cluster-to-cluster-sync ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Thanks @shuangela LGTM - nice job keeping the style consistent with the other examples!
source/reference/api/start.txt
Outdated
| The following example starts a sync job between the replica set ``cluster0`` and the | ||
| sharded cluster ``cluster1``. The source cluster is ``cluster0`` and the destination |
There was a problem hiding this comment.
The two first sentences here can be condensed
There was a problem hiding this comment.
Well I see that's the case everywhere else. I'll leave it up to you about if we should change it, but it seems like it should be condensed throughout the page into one sentence
There was a problem hiding this comment.
Good callout! I agree, I'll go in and condense all the descriptions to ensure consistency
source/reference/api/start.txt
Outdated
| The following example starts a sync job between the replica set ``cluster0`` and the | ||
| sharded cluster ``cluster1``. The source cluster is ``cluster0`` and the destination |
There was a problem hiding this comment.
Well I see that's the case everywhere else. I'll leave it up to you about if we should change it, but it seems like it should be condensed throughout the page into one sentence
source/reference/api/start.txt
Outdated
| @@ -366,8 +366,8 @@ Start Sync from Replica Set to Sharded Cluster | |||
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | |||
|
|
|||
| The following example starts a sync job between the replica set ``cluster0`` and the | |||
| sharded cluster ``cluster1``. The source cluster is ``cluster0`` and the destination | |||
| cluster is ``cluster1``. The ``key`` array in this example defines the shard key ``{"location": 1, "region": 1 }``. | |||
| sharded cluster ``cluster1``. The ``key`` array in this example defines the shard key | |||
There was a problem hiding this comment.
we should still say that cluster0 is the source and 1 is the destination
* add explaination * condense wording * add source and destination (cherry picked from commit 9734cd3)
* add explaination * condense wording * add source and destination (cherry picked from commit 9734cd3)
* add explaination * condense wording * add source and destination (cherry picked from commit 9734cd3)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
DESCRIPTION
Adds details on shard key in mongosync api example
STAGING
https://deploy-preview-732--docs-cluster-to-cluster-sync.netlify.app/reference/api/start/
JIRA
https://jira.mongodb.org/browse/DOCSP-48400
SELF-REVIEW CHECKLIST
See the taxonomy tagging instructions and this example PR
EXTERNAL REVIEW REQUIREMENTS
What's expected of an external reviewer?