-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Laravel 10.x Compatibility #2501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
⚗️ Using this package? If you would like to help test these changes or believe them to be compatible, you may update your project to reference this branch. To do so, temporarily add Shift's fork to the {
"repositories": [
{
"type": "vcs",
"url": "https://github.com/laravel-shift/laravel-mongodb.git"
}
]
} Then update your dependency constraint to reference this branch: {
"require": {
"jenssegers/mongodb": "dev-l10-compatibility",
}
} Finally, run: |
"illuminate/database": "^9.0", | ||
"illuminate/events": "^9.0", | ||
"mongodb/mongodb": "^1.11" | ||
"illuminate/support": "^10.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make sense to support both Laravel 9.x and 10.x at the same time? I'm not too familiar with the amount of BC breaks that Laravel 10 will bring, but if it's possible to support both without a big hassle, users would profit from that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sadly, that wouldn't be possible there are indeed BC. Upgrading to the latest version of Laravel would be better for the users instead of staying on the older version.
"phpunit/phpunit": "^9.5.10", | ||
"orchestra/testbench": "^8.0", | ||
"mockery/mockery": "^1.4.4", | ||
"doctrine/dbal": "^3.5" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note to self: we should try to get rid of this dependency. With Laravel itself no longer depending on it, we should be able to drop the dependency as well at some point.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to get rid of a lot things, library needs a complete revamp even though the new version of Laravel comes soon.
@@ -41,7 +41,6 @@ jobs: | |||
- '4.4' | |||
- '5.0' | |||
php: | |||
- '8.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New laravel doesn't work with php 8.0? Why you delete 8.0 from matrix in CI?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/laravel/framework/blob/10.x/composer.json#L18
I suggest to include if condition in ci
If laravel version >= 10.0 then on php 8.0 ci step will be disabled
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- laravel/framework 10.x-dev requires php ^8.1 -> your php version (8.0.27) does not satisfy that requirement.
- illuminate/support 10.x-dev requires php ^8.1 -> your php version (8.0.27) does not satisfy that requirement.
Closed in favor #2506 |
This is an automated pull request from Shift to update your package code and dependencies to be compatible with Laravel 9.x.
Before merging, you need to:
l10-compatibility
branchIf you do find an issue, please report it by commenting on this PR to help improve future automation.