-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Fix tests for MongoDB 7.0 #2579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,24 +1,21 @@ | ||
ARG PHP_VERSION=8.1 | ||
ARG COMPOSER_VERSION=2.5.4 | ||
|
||
FROM php:${PHP_VERSION}-cli | ||
|
||
RUN apt-get update && \ | ||
apt-get install -y autoconf pkg-config libssl-dev git libzip-dev zlib1g-dev && \ | ||
apt-get install -y autoconf pkg-config libssl-dev git unzip libzip-dev zlib1g-dev && \ | ||
pecl install mongodb && docker-php-ext-enable mongodb && \ | ||
pecl install xdebug && docker-php-ext-enable xdebug && \ | ||
docker-php-ext-install -j$(nproc) pdo_mysql zip | ||
|
||
COPY --from=composer:${COMPOSER_VERSION} /usr/bin/composer /usr/local/bin/composer | ||
COPY --from=composer:2.5.8 /usr/bin/composer /usr/local/bin/composer | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Having it at the top of the file made it easier to locate the version for an update, but no objection to inlining it. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It doesn't work with my setup.
There is a workaroud if I alias the composer image. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ah, no worries then 👍 |
||
|
||
WORKDIR /code | ||
|
||
COPY composer.* ./ | ||
|
||
RUN composer install | ||
|
||
COPY ./ ./ | ||
|
||
ENV COMPOSER_ALLOW_SUPERUSER=1 | ||
|
||
RUN composer install | ||
|
||
CMD ["./vendor/bin/phpunit"] | ||
CMD ["./vendor/bin/phpunit", "--testdox"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where does
mongosh
come from? IIRC it's not distributed with the server package, so if we download it separately we should be able to use it with 4.4 as well.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is in the mongodb docker image. We can remove this line after February 2024 when support for 4.4 will end.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I see. Fine with me :)