LG-4952: Updates Modal component to use dialog element #2579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: cce69e7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
bruugey
commented
Dec 5, 2024
|
Size Change: -1.93 kB (-0.13%) Total Size: 1.47 MB
ℹ️ View Unchanged
|
bruugey
changed the title
…ui into brooke/modal-updates
stephl3
reviewed
Mar 5, 2025
packages/confirmation-modal/src/ConfirmationModal/ConfirmationModal.spec.tsx
Show resolved
Hide resolved
| }, [portalRef]) | ||
|
|
||
| <Modal portalRef={portalRef}> | ||
| <Select renderMode="portal" portalContainer={containerState.current}/> |
There was a problem hiding this comment.
if we continue using a PortalContextProvider in Modal.tsx, it should improve the consumer experience since they won't need to specify portalContainer in each popover instance that uses renderMode="portal"
There was a problem hiding this comment.
Updated to what I think makes sense but let me know
| }; | ||
|
|
||
| useEffect(() => { | ||
| if (localRef.current != null) { |
There was a problem hiding this comment.
nit: could invert and early return for readability
stephl3
reviewed
Mar 5, 2025
stephl3
reviewed
Mar 18, 2025
| `; | ||
|
|
||
| export const modalContentStyle = css` | ||
| const dialogContentStyle = (theme: Theme) => css` |
There was a problem hiding this comment.
dialog native styles clip any content that overflows. for the case of popovers that portal or render inline, we may need to override with overflow: visible
Co-authored-by: Stephen Lee <[email protected]>
Co-authored-by: Stephen Lee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Proposed changes
🎟 Jira ticket: LG-4952
✅ Checklist
For bug fixes, new features & breaking changes
yarn changesetand documented my changesFor new components
🧪 How to test changes