Updates Menu Backdrop behavior #2767
Merged
+296
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 94909bb The changes in this PR will be included in the next version bump. This PR includes changesets to release 83 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This reverts commit 95bf339.
|
Size Change: +457 B (+0.03%) Total Size: 1.48 MB
ℹ️ View Unchanged
|
shaneeza
reviewed
Mar 31, 2025
packages/lib/src/getClosestFocusableElement/getClosestFocusableElement.tsx
Outdated
Show resolved
Hide resolved
shaneeza
reviewed
Mar 31, 2025
packages/lib/src/getClosestFocusableElement/getClosestFocusableElement.tsx
Outdated
Show resolved
Hide resolved
shaneeza
reviewed
Mar 31, 2025
| <MenuItem>Item A</MenuItem> | ||
| <MenuItem>Item B</MenuItem> | ||
| </Menu> | ||
| <Button data-testid="outside-button" onClick={otherButtonHandler}> |
shaneeza
reviewed
Mar 31, 2025
| @@ -42,12 +73,28 @@ export function useBackdropClick( | |||
| * 5. Then we call the callback (typically fires `closeMenu`, setting `isOpen = false`, and rerender the component) | |||
| */ | |||
|
|
|||
| // TODO: Remove this in a major version | |||
shaneeza
reviewed
Mar 31, 2025
shaneeza
reviewed
Mar 31, 2025
|
|
||
| const handleClose = useCallback( | ||
| (event?: MouseEvent | React.MouseEvent) => { | ||
| // TODO: move this logic to useBackdropClick |
shaneeza
reviewed
Mar 31, 2025
| @@ -199,6 +228,7 @@ export const Menu = React.forwardRef<HTMLDivElement, MenuProps>(function Menu( | |||
| onEntered={handlePopoverOpen} | |||
| data-testid={LGIDs.root} | |||
| data-lgid={LGIDs.root} | |||
| ref={popoverRef} | |||
There was a problem hiding this comment.
b/c the popover ref should be on the popover element
I'll add to the changeset
shaneeza
approved these changes
Mar 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hooks:
useBackdropClickto accept an options object. Retains (but deprecates) boolean-only functionality.options.allowPropagationto allow or disallow the click event to bubble up to other elements.Lib
Adds
getClosestFocusableElement.This function crawls up the DOM tree to find the closest focusable element to the provided element
Returns the element itself if it is focusable or if no focusable element is found, it returns the body element.
Menu: